Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan package #35

Open
mristin opened this issue Nov 21, 2018 · 5 comments
Open

Conan package #35

mristin opened this issue Nov 21, 2018 · 5 comments

Comments

@mristin
Copy link
Collaborator

mristin commented Nov 21, 2018

Hi,
Have you considered making a conan package?

If not, would you mind if we make one? In that case, could you please bump the version to 1.0.0 so that we can pin it down?

Thanks!

@mavam
Copy link
Owner

mavam commented Nov 21, 2018

So far I haven't considered making a Conan package. Unfortunately I lack the cycles at the moment to polish the repository. But I'd be more than happy to discuss and review pull requests.

@mristin
Copy link
Collaborator Author

mristin commented Nov 22, 2018

Thanks for your help! We'll hopefully have some time to look at it tomorrow.

Could you please bump the version to 1.0.0 so that we can pin it down? (There were ~40 commits since the beta release, so I suppose beta is not applicable anymore.)

I'd recommend you to version the code with semver schema to make it a bit easier to trace (https://semver.org/).

@mristin
Copy link
Collaborator Author

mristin commented Nov 26, 2018

Hi @mavam ,
If you make me a collaborator, I can also make a new release for you.

@mavam
Copy link
Owner

mavam commented Nov 29, 2018

That'd be wonderful, I sent you an invite.

@mristin
Copy link
Collaborator Author

mristin commented Dec 4, 2018

Thanks, I bumped to version 1.0.0.
Let's implement serialization (#17) before we proceed to the conan package since major version bumps might follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants