Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some shaders look different than in RetroArch #135

Open
Nightskyy1 opened this issue Mar 15, 2025 · 8 comments
Open

Some shaders look different than in RetroArch #135

Nightskyy1 opened this issue Mar 15, 2025 · 8 comments
Labels
support Help with using SG

Comments

@Nightskyy1
Copy link

I would like to use crt-hyllian-3d and crt-guest-advanced-hd. These shaders are made to use with a higher internal resolution for 3D games. I tried these shaders in RetroArch at 4x internal resolution with GameCube and PS2. After that I tried the same with ShaderGlass. But it looked different with ShaderGlass. I adjusted the shader parameters in both cases to 4x internal resolution. With ShaderGlass it didn't look very good, so I think there is an issue with these shaders.

@mausimus
Copy link
Owner

mausimus commented Mar 15, 2025

Hm they look pretty equal to me in an image test so it's probably something to do with scaling. SG doesn't have an option to upscale source (pixel size option only downscales) so for something like crt-hyllian-3d you'll need to have your source window show the game at 4x scale for example, set pixel size to 1 in SG (=no downscaling) and 4 internal resolution as shader param. Doom looks pretty good that way. A lot of shaders have been written with RA cores' specifics in mind and don't work as easily in SG, tweaking is often required (contrary to RA, SG knows nothing about your input).

Image

@mausimus mausimus added the support Help with using SG label Mar 15, 2025
@mausimus
Copy link
Owner

I've added #136 to add source upscaling to SG to make this easier to accomplish.

@Nightskyy1
Copy link
Author

Thanks for the help. Here are two screenshots with crt-hyllian-3d. One is with RetroArch and one with ShaderGlass. It's PS2 with 4x resolution (1440p monitor). I made sure that the shader parameters are also set to 4x internal resolution. I also set ShaderGlass to 1x pixel size. The text looks slightly worse with ShaderGlass.

Image
Image

@Nightskyy1
Copy link
Author

The first one is RetroArch, the second one is ShaderGlass.

@mausimus
Copy link
Owner

There's fewer scanlines on SG version; are you sure you need to scale x4, not x3 (isn't PS2 480 vertical)?

@Nightskyy1
Copy link
Author

That's what I would've thought too. But Dolphin and PCSX2 recommend 4x for 1440p. Here is a screenshot from PCSX2.

Image

@mausimus
Copy link
Owner

Not sure what PCSX2 is doing there, I haven't used it myself. Try 3x, if it doesn't help, maybe I'll install it someday.

@Nightskyy1
Copy link
Author

This is ShaderGlass with crt-hyllian-3d. The internal resolution of the game is 3x. The shader parameters are set to 3x also. The pixel size is 1x. There are no visible scanlines and the picture looks worse. So I think 4x is correct for 1440p. Unfortunately ShaderGlass looks slightly worse with this shader than RetroArch with 4x, especially text.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Help with using SG
Projects
None yet
Development

No branches or pull requests

2 participants