Multi-target tests to netcoreapp3.1 and net48

[mauroservienti]

There is no need to target net5 or net6, netcoreapp3.1 is sufficient unless we explicitly need new SDK features. Targeting net48 allows testing endpoints still using the .NET Framework.

[Tobias-08]

Hi @mauroservienti ,

is it possible to multitarget net48, too?

We have still endpoints that use net48 because of certain dependencies and testing them with netcoreapp3.1-NServiceBus.IntegrationTesting seems to cause some issues.

[mauroservienti]

It's technically possible (see #191 and #192) the only issue I see is that it would be impossible to have in the same acceptance test a net48 endpoint and a netcoreapp3.1 one.

[Tobias-08]

Great, LGTM. That it's impossible to mix endpoints with different target framework is OK for me (and by design). But that hint could be added to the readme.

[mauroservienti]

@Tobias-08 I just created 1.2.0, once the build is completed, I'll push to nuget.

[Tobias-08]

@mauroservienti Thanks! Unfortunately I have issues in test execution while using 1.2.0 with net48:

System.TimeoutException : Starting endpoints took longer than 2 minutes.

I have seen this with netcoreapp3.1, too, but not in every test run.

This might be specific to my setup but I have no concrete idea what might be wrong on my side.

[mauroservienti]

I'm sorry about that @Tobias-08. I faced a similar issue when implementing multi-targeting in tests running on Linux. All tests were timing out no matter what. The fix for the Linux tests was to force tests to run on a specific test framework, e.g.:

dotnet test [projectname] --framework netcoreapp3.1 --configuration Release

Commit here

I have no idea what could be the underlying issue, but that fixed the specific problem.

That being said, you should have the full test logs available, if it's possible would you mind sharing those with me?

Another thing, would you be able to download the bits from #194 and run the tests in the MySystem.AcceptanceTests project and report back here what's happening?

[Tobias-08]

The --framework parameter does not make a difference on my side (and my scenario does not use multi-targeting). Excerpt from the log:

<ErrorInfo> <Message>System.TimeoutException : Starting endpoints took longer than 2 minutes.</Message> <StackTrace> at NServiceBus.AcceptanceTesting.Support.TaskExtensions.&lt;Timebox&gt;d__0.MoveNext() in /_/src/NServiceBus.AcceptanceTesting/Support/TaskExtensions.cs:line 23&#xD; --- End of stack trace from previous location where exception was thrown ---&#xD; at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)&#xD; at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#xD; at NServiceBus.AcceptanceTesting.Support.ScenarioRunner.&lt;PerformScenarios&gt;d__2.MoveNext() in /_/src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs:line 72&#xD; --- End of stack trace from previous location where exception was thrown ---&#xD; at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#xD; at NServiceBus.AcceptanceTesting.Support.ScenarioRunner.&lt;PerformScenarios&gt;d__2.MoveNext() in /_/src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs:line 105&#xD; --- End of stack trace from previous location where exception was thrown ---&#xD; at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)&#xD; at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#xD; at NServiceBus.AcceptanceTesting.Support.ScenarioRunner.&lt;PerformTestRun&gt;d__1.MoveNext() in /_/src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs:line 49&#xD; --- End of stack trace from previous location where exception was thrown ---&#xD; at NServiceBus.AcceptanceTesting.ScenarioWithContext1.<Run>d__2.MoveNext() in /_/src/NServiceBus.AcceptanceTesting/ScenarioWithContext.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult()
 at Elfe.Integrator.IntegrationTests.IntegrationTests.<TestWholeElfeProcess_ValidAntragVorabmeldungTimeout_ElterngeldAntragVersendet>d__4.MoveNext() in C:\src\Elfe.Integrator\Elfe.Integrator\Elfe.Integrator.IntegrationTests\IntegrationTests.cs:line 63
 --- End of stack trace from previous location where exception was thrown ---
 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
 at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter1.BlockUntilCompleted()
 at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
 at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func1 invoke)
at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
`

The bits from #194 result in errors:

OneTimeSetUp: System.ComponentModel.Win32Exception : The system cannot find the file specified