-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebVTT thumbs do not work, if the list doesn't start with 00:00.000 #56
Comments
...and it also doesn't like additional cue identifiers (as provided by the WebVTT specification)... |
mash-graz
pushed a commit
to mash-graz/videoscripts
that referenced
this issue
Mar 3, 2020
* the presence of the 'sips' executable is now autodetected to let it work out of the box on non-mac machines * TIMESYNC_ADJUST isn't neccessary on more recent ffmpeg executables. if not set to -1 the time stamps will not start with 0:00.000, which is not accepted by some applicationes (see: matvp91/indigo-player#56) * explicit cue identifierers in the output don't make much sense and also tend to be incompatible. (e.g. in case of indigo-player)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
if the entries in the .vtt file do not start with 00:00.000, which is unfortunately the default behavior, if you use [makesprites.py] and do not manually set the TIMESYNC_ADJUST constant to -1, Indiego-player will not show any thumbs on the cue/progress-bar.
To Reproduce
just manually modify the first entry of a working .vtt-file and increment the start time
Expected behavior
well -- it's in fact a flaw of another application, but nevertheless it would be nice, if indigo-player could tolerate this kind of vtt-files, because the actual cause for this issue rather hard to debug for most users.
[btw: i have to say, your player is IMHO by far the best available open source video player right now! :) ]
The text was updated successfully, but these errors were encountered: