New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Favicons #84

Open

ndorfin opened this issue Sep 15, 2021 · 0 comments

Contributor

ndorfin commented Sep 15, 2021 •

edited

Loading

I noticed there are the following files in the hell/favicon folder:

favicon-16x16.png
favicon-32x32.png
favicon.ico

It looks like the favicon.ico already has the 16x16, 32x32, and 48x48 sizes incorporated:

The two PNGs are referenced using the following in base.njk:

<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">

I'd suggest the following:

Delete the PNGs
Delete the rel="icon" references to the PNGs
Add a custom g-zip header for favicon.ico to your Netlify config. (ICO files are like BMPs, they compress nicely)

The browser will do the rest.

Outcomes:

Less HTML bytes
Reduced file maintenance
Greater favicon operability with the 48x48 size included.

How about that? :D

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment