Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo SVG and usage improvements #80

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ndorfin
Copy link
Contributor

@ndorfin ndorfin commented Sep 15, 2021

Hey @matuzo

Fixes #74

In this PR

The bulk of this PR is to do with logo usage

  • Logo enhancments as per Logo SVG improvements #74 (Refactored, minified)
  • Replace the logo.txt XHR script with an inlined SVG in the HTML
  • Remove obsolete logo animation styles (?)
  • Replace the pentagramm.svg and pentagramm-light.svg versions with the new structure.

Notes

  • Unfortunately, the mask has to be repeated inside each child SVG (where we <use> the pentacle <circle>), since Chromium/Webkit browsers don't allow for external URI <mask>s.
  • At some point, we could replace pentagramm(-light).svg with inline versions, and therefore re-using the SVG sprite.
  • We could use logo.svg in the Web Manifest, and Safari pinned tab mask. I'll leave that for PWA icon fixes.

Results

The logo improvments can be seen in the comments on #74

As for site performance, rudimentary testing on my local environment yielded:

  • Total bytes (un-gzipped)
    • 125kB (before)
    • 102kB (after)
  • HTML bytes (un-gzipped)
    • 21kB (before)
    • 56kB (after)

The HTML payload is now 11kB g-zipped, which keeps us below the 14kB threshhold.

Waddayathink?
-S

@ndorfin ndorfin marked this pull request as ready for review September 15, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo SVG improvements
1 participant