Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporting global expect constant #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miki725
Copy link

@miki725 miki725 commented Nov 2, 2022

otherwise in some editors (in my case vim tsserver LSP), the global type is still native jest type, and so additional parameters are not honored

by exporting expect constant, that makes it explicit that global expect is overwritten

What

exporting global expect constant for typescript support

Why

Some LSP servers do not pickup updated expect global and so complain that additional parameters are not supported

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings

otherwise in some editors (in my case vim tsserver LSP), the global type is still native jest type, and so additional parameters are not honored

by exporting expect constant, that makes it explicit that global expect is overwritten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant