Skip to content

Commit ba1e537

Browse files
committed
Refactoring a little bit
1 parent 2473ce9 commit ba1e537

File tree

1 file changed

+7
-21
lines changed

1 file changed

+7
-21
lines changed

crates/config/src/zksync.rs

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use era_solc::standard_json::input::settings::{error_type::ErrorType, warning_type::WarningType};
2-
use core::iter;
32
use foundry_compilers::{
43
artifacts::{EvmVersion, Libraries, Severity},
54
error::SolcError,
@@ -22,10 +21,7 @@ use foundry_zksync_compilers::{
2221
};
2322
use semver::Version;
2423
use serde::{Deserialize, Serialize};
25-
use std::{
26-
collections::{BTreeMap, HashSet},
27-
path::PathBuf,
28-
};
24+
use std::{collections::HashSet, path::PathBuf};
2925

3026
use crate::{Config, SkipBuildFilters, SolcReq};
3127

@@ -169,8 +165,11 @@ pub fn config_zksolc_settings(config: &Config) -> Result<ZkSolcSettings, SolcErr
169165
Err(e) => return Err(SolcError::msg(format!("Failed to parse libraries: {e}"))),
170166
};
171167

172-
let x = <std::option::Option<SolcReq> as Clone>::clone(&config.zksync.zksolc).unwrap();
173-
let version = x
168+
let version = config
169+
.zksync
170+
.zksolc
171+
.clone()
172+
.ok_or_else(|| SolcError::msg("zksolc version is not set"))?
174173
.try_version()
175174
.map_err(|e| SolcError::msg(format!("Failed to parse zksolc version: {e}")))?;
176175

@@ -185,18 +184,10 @@ pub fn config_create_project(
185184
cached: bool,
186185
no_artifacts: bool,
187186
) -> Result<Project<ZkSolcCompiler, ZkArtifactOutput>, SolcError> {
188-
let settings = config_zksolc_settings(config)?;
189-
190-
print!("settings: {:?}", settings);
191-
192187
let mut builder = ProjectBuilder::<ZkSolcCompiler, ZkArtifactOutput>::default()
193188
.artifacts(ZkArtifactOutput {})
194189
.paths(config_project_paths(config))
195-
.settings(settings.clone())
196-
.additional_settings(BTreeMap::from_iter(iter::once((
197-
"zksyn2c".to_string(),
198-
settings.into(),
199-
))))
190+
.settings(config_zksolc_settings(config)?)
200191
.ignore_error_codes(config.ignored_error_codes.iter().copied().map(Into::into))
201192
.ignore_paths(config.ignored_file_paths.clone())
202193
.set_compiler_severity_filter(if config.deny_warnings {
@@ -232,11 +223,6 @@ pub fn config_create_project(
232223

233224
let zksolc_compiler = ZkSolcCompiler { zksolc, solc: config_solc_compiler(config)? };
234225

235-
// builder.additional_settings(BTreeMap::from_iter(iter::once((
236-
// "zksync".to_string(),
237-
// settings.into(),
238-
// ))));
239-
240226
let project = builder.build(zksolc_compiler)?;
241227

242228
if config.force {

0 commit comments

Comments
 (0)