Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations not showing with working_directory option #20

Open
negebauer opened this issue Aug 10, 2020 · 0 comments
Open

Annotations not showing with working_directory option #20

negebauer opened this issue Aug 10, 2020 · 0 comments

Comments

@negebauer
Copy link
Contributor

When I configured the action to run using working_directory it worked okay but the annotations where not shown in the PR files section. But they were shown when checking the job itself in the Checks tab.

Given working_directory: 'packages/web-ui'

The annotation was shown as

Screen Shot 2020-08-10 at 18 21 33

And the path src/components doesn't really exist, it should be packages/web-ui/src/components

I then changed my configuration to not use working_directory and run the test command from the root, which resulted in this annotation

Screen Shot 2020-08-10 at 18 23 03

Which was shown correctly in the files tab.

Looking into the code I think the culprit is the following line

path: result.name.replace(cwd, ""),

Where the whole cwd is being deleted, but if working_directory was defined it's also part of that string and it shouldn't be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant