Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update columns used for ecommerce goal pages #23121

Open
wants to merge 4 commits into
base: 5.x-dev
Choose a base branch
from
Open

Conversation

nathangavin
Copy link
Contributor

Description:

Current Ecommerce goal pages are not showing the correct data. This is addressed by adding logic to select different columns depending on the display type for the underlying report.

Addresses issue #20857

Review

@nathangavin nathangavin requested a review from a team March 13, 2025 00:23
@nathangavin nathangavin added the Needs Review PRs that need a code review label Mar 13, 2025
@michalkleiner
Copy link
Contributor

@nathangavin this looks like it could solve the issue, before a proper review can you please check if any tests need adjusting as well? At a glance there might be some. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants