Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public_options in IsolatedComponents not working in 3.2.0.beta #3

Open
tangopium opened this issue Dec 15, 2022 · 1 comment
Open
Assignees
Milestone

Comments

@tangopium
Copy link
Contributor

When using an isolated components, there is the option to pass parameters via the public_options. In matestack-ui-vuejs 3.2.0 beta this variable can still be passed to the isolated components, but is not made visible anymore (inside the component it is empty). Taking a look at the source code, I noticed a new public_context, which is working in the expected way.

Suggestion: remove the public_options completely from isolated components to avoid this "silent failure". In this case, the component would raise an error, letting the user know, that public_options cannot be used anymore

@jonasjabari
Copy link
Member

Sorry for the late response, I will take care of this. We're currently working on releasing 3.2.0 officially. I'm planning on supporting both public_options and public_context in order to not introduce breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants