Skip to content

Commit d7c651a

Browse files
committed
restore BoltzTraP2 optional dep pinned to >=24.1.1
1 parent 9751f96 commit d7c651a

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ jobs:
6767
continue-on-error: true # This is not critical to succeed.
6868
- name: Install dependencies
6969
run: |
70-
python -m pip install --upgrade pip wheel
71-
7270
# TODO remove next line installing ase from main branch until FrechetCellFilter is released
7371
pip install git+https://gitlab.com/ase/ase
7472

.github/workflows/test.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,10 @@ jobs:
9797
continue-on-error: true # This is not critical to succeed.
9898
- name: Install dependencies
9999
run: |
100-
python -m pip install numpy cython
101-
102100
# TODO remove next line installing ase from main branch until FrechetCellFilter is released
103-
pip install git+https://gitlab.com/ase/ase
101+
python -m pip install git+https://gitlab.com/ase/ase
104102
103+
python -m pip install numpy cython
105104
python -m pip install -e '.[dev,optional]'
106105
107106
- name: pytest split ${{ matrix.split }}

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,9 @@
6868
],
6969
"optional": [
7070
"ase>=3.22.1",
71-
# TODO restore BoltzTraP2 when install fixed, hopefully following merge of
71+
# BoltzTraP2 install was fixed in
7272
# https://gitlab.com/sousaw/BoltzTraP2/-/merge_requests/18
73-
# caused CI failure due to ModuleNotFoundError: No module named 'packaging'
74-
# "BoltzTraP2>=22.3.2; platform_system!='Windows'",
73+
"BoltzTraP2>=24.1.1; platform_system!='Windows'",
7574
"chemview>=0.6",
7675
"chgnet",
7776
"f90nml>=1.1.2",

0 commit comments

Comments
 (0)