You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If all children of a landmark have CSS float, the landmark height is 0px.
This looks "off" when the highlight box is drawn around the landmark.
For example, the nav inside the banner on https://www.paciellogroup.com/
How about making a rudimentary guess at the height of a 0px-high landmark by using the height of the first child (well, the first one that has height)? I realize that won't be correct all the time, but maybe it will catch a bunch of cases? Just a thought. :)
The text was updated successfully, but these errors were encountered:
I've noticed this before, and wondered if there are any good heuristics that could be used. What you suggest sounds reasonable. I plan to look into it for the next release, though may need to test it for a while before it can be be released. If there's a reliable way to figure out the height of all contained elements, and it isn't too slow, that might be the way to go.
My concern about his before is that it may produce misleading results for devs (implying the landmark is somewhere else), though the DevTools panel would help address that, and the "flat" landmark does look confusing to someone who isn't a developer.
If all children of a landmark have CSS float, the landmark height is 0px.
This looks "off" when the highlight box is drawn around the landmark.
For example, the nav inside the banner on https://www.paciellogroup.com/
How about making a rudimentary guess at the height of a 0px-high landmark by using the height of the first child (well, the first one that has height)? I realize that won't be correct all the time, but maybe it will catch a bunch of cases? Just a thought. :)
The text was updated successfully, but these errors were encountered: