Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to sort out terser code indentation #196

Open
matatk opened this issue Aug 9, 2018 · 2 comments
Open

Try to sort out terser code indentation #196

matatk opened this issue Aug 9, 2018 · 2 comments

Comments

@matatk
Copy link
Owner

matatk commented Aug 9, 2018

Had to use rollup-plugin-esformatter because the output from terser was a indented a bit oddly sometimes. Sense I might need to come up with a minimal test case for this, which could take a while. Would like to remove the extra dependency if possible.

@matatk matatk self-assigned this Aug 9, 2018
@matatk matatk added this to the 2.5.0 milestone Sep 4, 2018
@matatk matatk modified the milestones: 2.5.0, 2.4.x Dec 6, 2018
@matatk
Copy link
Owner Author

matatk commented Dec 9, 2018

Just tried it without the plugin and it still doesn't work; no cycles at the moment to attempt to fix it, so will continue with the plugin for now. It does cause some npm audit warnings, but seemingly nothing serious (though of course ideally I'd like to get these fixed).

@matatk matatk removed this from the 2.4.x milestone Dec 9, 2018
@matatk matatk added this to the next milestone Feb 8, 2021
@matatk
Copy link
Owner Author

matatk commented Aug 7, 2021

Using rollup-plugin-prettier since 665236b

@matatk matatk removed this from the next milestone Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant