Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options UI cleanups #157

Open
matatk opened this issue May 8, 2018 · 2 comments
Open

Options UI cleanups #157

matatk opened this issue May 8, 2018 · 2 comments
Assignees
Milestone

Comments

@matatk
Copy link
Owner

matatk commented May 8, 2018

Now that there are several options relating to the border drawn around landmarks, it makes sense to clear up the UI a bit. This may be left as-is until headings are supported too, but when they are, the following probably make sense:

  • Instead of having momentary/persistent/none as border showing settings, there should be an overall "Show landmark (or heading) borders?" option for each type of border.
  • Having each group of options under a <fieldset>.
  • Putting advanced options (currently only the one, debugging) under a disclosure widget.
  • Adding help info directly into the options page.

Should the options page be made more visible? I have resisted this so far, as there are already mechanisms provided by the browser to access extensions' options.

@matatk matatk added this to the 3.0.0 milestone May 8, 2018
@matatk matatk self-assigned this May 8, 2018
@matatk
Copy link
Owner Author

matatk commented May 11, 2018

Layout considerations: separate panels for landmarks and headings, or a more table-like approach?

@matatk matatk changed the title Options UI Cleanups Options UI cleanups May 11, 2018
@matatk
Copy link
Owner Author

matatk commented Oct 26, 2018

It could be that some users might want to use the pop-up for landmarks and the sidebar for headings, so it should be possible to support that.

matatk added a commit that referenced this issue Feb 2, 2020
* Move to a stand-alone options page on all browsers (taking some inspiration from  #157).
* Streamline the content of the Help page.
* Streamline styles.

Closes #227. Fixes #288. Closes #226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant