Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReportStatusTableViewCell #1206

Open
kimar opened this issue Jan 8, 2024 · 5 comments
Open

Refactor ReportStatusTableViewCell #1206

kimar opened this issue Jan 8, 2024 · 5 comments
Assignees
@somkuwaryash
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kimar
Copy link
Member

kimar commented Jan 8, 2024

Rationale

The ReportStatusTableViewCell only contains a very shallow ViewModel which could be removed with it's contained properties being added to the Cell directly.
@kimar kimar added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2024
@kimar kimar mentioned this issue Jan 8, 2024
Merged
@somkuwaryash
Copy link

Hey,can i take on this issue?

@kimar
Copy link
Member Author

kimar commented Jan 9, 2024

@somkuwaryash sure 👍 please go ahead and raise a PR once you're ready with the changes.

@zeitschlag
Copy link
Member

I was about to write that, but Marcus was faster :D

@somkuwaryash Thank you for your offer, we really appreciate that!
If there's anything you need help with: Please ask, we're here to help :)

@ali-ahsan-ali
Copy link

Seeing as it has been 5 months. Can I also take a look at this issue. Could be a race to the solution ;)

@ali-ahsan-ali ali-ahsan-ali mentioned this issue May 6, 2024
Open
@ali-ahsan-ali
Copy link

ali-ahsan-ali commented May 6, 2024 •
edited

Race is over? That was quick. Maybe I should have left this for someone newer to programming in swift. Atleast I grew some confidence and maybe can tackle some harder issues.

Please take a look @zeitschlag @kimar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somkuwaryash somkuwaryash

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kimar @zeitschlag @ali-ahsan-ali @somkuwaryash