-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input method behaviour #43
Comments
WIth pgtk-use-im-context, he in #30 seems not to be able to use reverse-im.el. Should he disable pgtk-use-im-context explicitly? EDIT: |
Fair enough. How does vanilla emacs provide this basic support for prefix keys? I just hope pgtk to not introduce regressions. |
Here, For you, XLookupString is suitable. XLookupString takes compose_status as the last argument, which must be for you. And, how to decide whether the frame should have XIC. It is set here in create_frame_xic, which is called from here only when use_xim is true. use_xim is set around here and here. It is controlled by configure option and X resources. Maybe your use_xim and his are different. |
@Svadkos Thanks for the comment. @A6GibKm I'll change to enable by default. |
Tested #44 and it is indeed enabled by default 👍 . I have a unrelated question, I was looking at this emacs-devel thread, are there plans to allow building against gtk4? the most interesting feature is the gpu acceleration, which as far as I know can be only be achieved in emacs using this PR at remacs. |
Thanks for the testing, but it needs more code. Po Lu is developing Gtk4 support. If I apply his patch and push to here, the code becomes mine. If he makes a PR for my fork, I'll want to accept it. |
#44 is done. could you test again? |
Done, works. The env variable also correctly disables IM when set to |
Thanks for the testing. I also updated README.md. |
One of the goals of Wayland is to be transparent to the user, user facing features should not be different from their X counterpart.
On vanilla
emacs -Q
26.3, pressing´ a
results iná
on a spanish (Latin America) keyboard, the interface does not tell the user it is waiting after the prefix key´
has been pressed, this last part is not consistence with the global experience in gtk, where you see, for example(note the underline) on firefox or other gtk apps, when waiting for a key after the prefix
´
.On the
pgtk
branch, pressing´ a
onemacs -Q
wrongly insertsa
. AddingDoes fix the issue,
´ a
results iná
, and the behaviour is the expected one for a gtk app (the screenshot above is from pgtk Emacs).Suggestion
Since the default emacs behaviour is to recognize
á
, and the expected gtk behaviour is to recognize these bindings and to show this "waiiting" as in the screenshot,(pgtk-use-im-context t)
should be set as the default.My suggestion is to add a variable, named similarly to
pgtk-use-im-context
, to enable(pgtk-use-im-context t)
at startup, this variable is set tot
by default. From my experience, this kind of behaviours are generally handled via variables instead of functions, but as long as the defaults are what they should be expected it does not matter how this is implemented.P.S. This is the one remaining difference (regression) I can notice from vanilla Emacs, thanks for your great work.
The text was updated successfully, but these errors were encountered: