-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Performance For "MaxLineSize" and Concurrency of ParseString(line) #229
Comments
25k qps is a respectable workload 😳 -- admittedly, this is the heaviest workload that I've seen this exporter been subjected to. I'd be happy to include optimizations for such heavy workloads, however I can't make any promises as to when I'll actually find the time to get to that. In the meantime, I'm happy to accept any PRs in this matter. 🙂 |
Do you have a rule of thumb for the max qps that you know the exporter can handle without pegging the one core that it uses and falling behind on log processing? |
prometheus-nginxlog-exporter/tail/tailer.go
Line 44 in f09c9dc
add
MaxLineSize: 65534
to improve Throughput of reading file?prometheus-nginxlog-exporter/main.go
Line 372 in f09c9dc
to Concurrent Execute ParseString(line) in this loop?
over 25000 QPS access.log, exporter unable to update metrics accurately.
Tks.
The text was updated successfully, but these errors were encountered: