Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells styled with dim have strange colours #1157

Open
sansfontieres opened this issue Dec 8, 2023 · 3 comments
Open

Cells styled with dim have strange colours #1157

sansfontieres opened this issue Dec 8, 2023 · 3 comments
Labels

Comments

@sansfontieres
Copy link
Contributor

sansfontieres commented Dec 8, 2023

Following this conversation:

I get this funny outcome since this commit.
image
EDIT: I see, it seems to take the colour of vis.lexers.STYLE_LINENUMBER_CURSOR

Originally posted by @sansfontieres in #970 (comment)

; vis -v
vis v0.7-147-gf1abd79 +curses +lua

The original conversation had a screenshot on tmux, but the issue was observed on iTerm2 without any other terminal emulator over it. iTerm2 is set with $TERM=xterm-256color, tmux (3.3a) with $TERM=tmux-256color (but tmux-256color have other colours issues)

The issue was observed with ncursesw, not the old ncurses shipped with macOS.

; ./configure
[...]
checking for ncursesw... yes
[...]
; pkg-config --cflags ncursesw
-D_DARWIN_C_SOURCE -DNCURSES_WIDECHAR -I/opt/local/include

After applying #1154 (as 9dcda8d), the issue still persists.

I also observed that dimmed cells are not dimmed on Ghostty (only on vis afaik), but that's another issue on a terminal emulator in beta. I’ll keep an eye, though.

image

@sansfontieres
Copy link
Contributor Author

sansfontieres commented Dec 8, 2023

It crosses the splits too
image

Lemme know if something else can help you, like an asciinema recording or whatnot 😁

@mcepl
Copy link
Contributor

mcepl commented Dec 8, 2023

Looking at https://github.com/nc0fr/homebrew-nc0/issues/3 … is this the build you use? Do you use any patches from https://github.com/martanne/vis/wiki/Patches (those are horribly unmaintained and somebody should take a look at them and either include them or throw them away)?

@sansfontieres
Copy link
Contributor Author

I built directly from source (2 commits late), without patch (except #1154).

I also built vis without curses, to be sure, same issue.

@rnpnr rnpnr added the core:ui label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants