Zero work time in Science Tool and Science tab

[mokun]

Describe the bug

• Zero value in Science Tool's work column when total work is reportedly 75% completed

Expected and unexpected behavior

• Work in sols should be reported in "Study Detail" panel.

Java classes involved

• StudyDestailPanel, ScientificStudy

Screenshots
If "Phase Completed" is 75%, then a lot of work should have been done by the following collaborators but no work time is reported

Hong Kuang shows zero work in Research and Paperwork column

Specifications

• pre-3.8.0

Details

/**
 * A class representing a scientific study.
 */
public class ScientificStudy implements Entity, Temporal, Comparable<ScientificStudy> {
	// POJO holding collaborators effort
	private static final class CollaboratorStats implements Serializable {
		private static final long serialVersionUID = 1L;
		
		double acheivementEarned = 0D;
		double paperWorkTime = 0D;
		double reseachWorkTime = 0D;
		MarsTime lastContribution = null;
		ScienceType contribution;
		
		CollaboratorStats(ScienceType contribution) {
			this.contribution = contribution;
		}
	}

• The paperWorkTime and researchWorkTime are always zero.

[mokun]

@bevans2000

I don't know if it was after CollaboratorStats was added that the work time are no longer being tracked.

Can you see what went wrong ?

[bevans2000]

I'm pretty sure Collab stats were working. I will check the UnitTests to reproduce it

[bevans2000]

@mokun This is not a bug. If you look the Study is in the Invite Collaborators phase so no one can contribute yet.
I have expanded the LabTest Unit Test to check collaborators contribution and it is working fine. I will commit this.
Having said that, there r some minor improvements we can make to the Science Study tab.

[mokun]

no one can contribute yet.

But why would the Phase Completed shows 75% ?

See the screenshot above.

[mokun]

When I look through any science studies in Science Tool, I have yet to find anyone having done non-zero work.

What does Work mean ?

Even in Study Proposal phase, it should accumulate the work spent in sols. So far, it's always zero.

[bevans2000]

Because the Invite phase is that much completed. Each phase goes to 100% before advancing

[mokun]

Q: why is the first person's Contribution column always blank ?

[bevans2000]

No the logic has always been that work is only counted when research is actually being done via a Task
This would be a big change and definitely break the logic on

[mokun]

I assume the first person as the lead researcher would do research on a Subject as well, right ?

[bevans2000]

Primary researcher has to do the Science of the Study. This is a UI problem I can fix.