Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter running containers #596

Open
Vinnl opened this issue Mar 20, 2023 · 6 comments
Open

Filter running containers #596

Vinnl opened this issue Mar 20, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Vinnl
Copy link

Vinnl commented Mar 20, 2023

Describe your feature request

When looking at the Containers tab, if you have more than, say, five containers, it could be useful if you could filter the containers by name to quickly find the one you're looking for. (And I guess similar functionality would be useful for the lists of images and pods.)

@Vinnl Vinnl added the enhancement New feature or request label Mar 20, 2023
@marhkb
Copy link
Owner

marhkb commented Mar 26, 2023

Hi. Foremost, thanks for your report. Have you seen, there is already a global search/filter?

Bildschirmaufzeichnung.vom.2023-03-26.23-24-46.webm

I don't want to deny the usefulness of a filter per tab, but I don't know how to place it well together with the global filter without making the UI too cluttered.

@Vinnl
Copy link
Author

Vinnl commented Mar 27, 2023

I did not, thanks for that! I think I expected at search field at the top of every tab, which could disappear when going into global search mode, similar to e.g. this in Extension Manager:

image

However, looking at a couple of other applications, that doesn't seem a particularly common pattern, and it might clutter up the UI. So I guess it's a trade-off between discoverability and clutter.

Global search satisfies my use case though, so I'm happy!

@marhkb
Copy link
Owner

marhkb commented Apr 8, 2023

I am currently experimenting with a filter entry that is hidden by default. So, the global search shortcut would be re-assigned to Ctrl+Shift+F while the local filter will be assigned to Ctrl+F.

But at this point not sure whether this will land.

Bildschirmaufzeichnung.vom.2023-04-08.20-05-54.webm

@Vinnl
Copy link
Author

Vinnl commented Apr 9, 2023

Discoverability-wise that looks good, though honestly I'm using Ctrl+F all the time now, and it's actually pretty great that I don't need to switch to the "Containers" tab first to find my container, so it feels like a better default.

That said, maybe just a / if nothing is focused might be more aligned with how others apps do it? (Or maybe Ctrl+/?) In e.g. Firefox, that's Quick find as opposed to regular find, which feels as a somewhat similar use case? It's also a shortcut here on GitHub. Or just no keyboard shortcut.

Also, to avoid confusion of having two different Find icons, it might make sense to use a filter icon instead? Since it basically filters the Images/Containers/Pods that you're currently viewing.

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 8, 2023
@marhkb marhkb removed the stale label Jul 8, 2023
@marhkb
Copy link
Owner

marhkb commented Aug 12, 2023

See #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants