-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_chg bug #1
Labels
bug
Something isn't working
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The max_adv evaluation can misinterpret a one day drop as the maximum advance if it's greater than the actual max advance - it sees the high / low and makes the incorrect assumption that the price moved from the day low to the day high rather than the other way around! Without intraday data to determine which came first, will need to make an assumption guided by close or/and open prices (for example, if close closer to day high than assume it went up).
The opposite is probably also true, i.e. when evaluating a max decline it can probably assume a one day rise as the max decline if the rise is greater than the actual max dec. Need to investigate.
The text was updated successfully, but these errors were encountered: