Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function returning only unrelated results in macOS Terminal #18

Open
ameturpoet opened this issue Apr 10, 2022 · 2 comments
Open
Labels
bug Something isn't working question Further information is requested

Comments

@ameturpoet
Copy link

ameturpoet commented Apr 10, 2022

In macOS' default Terminal (macOS 12.3.1), the script always returns the same long list of nearly all games when given any search term. When using live search, any search term longer than 3 characters returns zero results, and any terms 3 or less returns the full list of all albums on the site.

(Also would it be possible to get a command flag to download different formats of a soundtrack when available, like FLAC or M4A? And maybe an option to change the default download location? That would be super useful!)

@marcus-crane
Copy link
Owner

Ah, sorry, I missed this issue being filed!

I'm running on macOS 12.3 Beta myself and I can't seem to replicate this issue with stock Terminal. Would you be able to attach a screen recording or something so I can understand the issue a bit better?

CleanShot 2022-05-22 at 15 10 18@2x

On the note of formats, I do intend to add support for those down the line. The layout for khinsider is quite annoying to parse (from a machine point of view) since there isn't much consistency but it is possible as much as it's annoying 😅

At the moment, the search is powered by https://github.com/marcus-crane/khinsider-index which works but means that when searching, you can't know ahead of time what formats are supported for an album since the file powering search only contains the album names and URLs.

When you go to download them, that's when this tool makes requests to see what formats are supported and so on.

My plan here is to do another rewrite where I update the indexer tool to scrape the site fully into a small database and then it becomes possible to surface much more info about each album such as is it an official OST, is it available for streaming (by way of VGMdb), does it have multiple formats, how many tracks does it have and so on.

Eventually I'll get around to it but partly I've got a few different side projects on the go and also I'm waiting for the recent changes to the site to settle down before I write a bunch of code and then have to throw it in the bin.

@marcus-crane marcus-crane added bug Something isn't working question Further information is requested labels May 22, 2022
@marcus-crane
Copy link
Owner

Closes: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants