Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to consume this library as a CommonJS module for use in Node.js #10

Open
kethinov opened this issue Jun 12, 2019 · 6 comments
Open

Comments

@kethinov
Copy link

I'm working on a Node.js command line app that needs to have IPS patching functionality. This repo has a lot of great functionality, but from what I can tell, it assumes consumption in the browser with a GUI. Would be nice to be able to do stuff like this:

// Node.js script
let romPatcher = require('RomPatcher')
romPatcher.patch(inputRomPath, inputIpsPath, outputRomPath)
// the above writes to outputRomPath using Node.js fs module
@marcrobledo
Copy link
Owner

Sounds pretty good.
Unfortunately, I haven't worked with Node.js.

I'll leave the issue open just in case someone feels free to implement this :-)

@joshterrill
Copy link

I haven't created a node module from a vanilla javascript project in a while, but I can take a look at this if help is still needed.

@kethinov
Copy link
Author

That'd be awesome. Nobody has worked on it yet.

@joshterrill
Copy link

Okay, I'll take a look at it this week.

@unsupo
Copy link

unsupo commented Jun 30, 2023

#61 should work for this

@kethinov
Copy link
Author

kethinov commented Jul 1, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants