Small improvements and little examples explanation fix.

Author: marcluque

client/src/main/java/de/datasec/hydra/client/Client.java

@@ -52,10 +52,8 @@ public HydraClient build() {
         }
 
         private HydraClient setUpClient() {
-            workerGroup = new NioEventLoopGroup(workerThreads);
-
             Bootstrap bootstrap = new Bootstrap()
-                    .group(workerGroup)
+                    .group(workerGroup = new NioEventLoopGroup(workerThreads))
                     .channel(NioSocketChannel.class)
                     .remoteAddress(host, port)
                     .handler(new HydraChannelInitializer(protocol, false));

client/src/test/java/client/ExampleClient.java

@@ -22,8 +22,9 @@ public static void main(String[] args) {
                 .build();
 
 
-        // Example for some things you can get from the session
+        // Checks if the client is connected to its remote host
         if (client.isConnected()) {
+            // Returns the session that was created for the client and its remote host
             session = client.getSession();
             System.out.println("Client is online!");
             System.out.printf("Socket address: %s%n", session.getAddress());

shared/src/main/java/de/datasec/hydra/shared/protocol/HydraProtocol.java

@@ -27,7 +27,22 @@ public class HydraProtocol {
 
     private HydraPacketListener packetListener;
 
-    public void registerPacket(Class<? extends Packet> clazz) {
+    public Packet createPacket(byte id) {
+        try {
+            return packets.get(id).newInstance();
+        } catch (InstantiationException | IllegalAccessException e) {
+            System.err.printf("Packet %s.class might hasn't got an empty constructor!%n\n", packets.get(id).getSimpleName());
+            e.printStackTrace();
+        }
+
+        return null;
+    }
+
+    public byte getPacketId(Packet packet) {
+        return packetBytes.get(packet.getClass());
+    }
+
+    protected void registerPacket(Class<? extends Packet> clazz) {
         if (clazz == null) {
             throw new IllegalArgumentException("clazz can't be null!");
         }
@@ -48,22 +63,7 @@ public void registerPacket(Class<? extends Packet> clazz) {
         packetBytes.put(clazz, id);
     }
 
-    public Packet createPacket(byte id) {
-        try {
-            return packets.get(id).newInstance();
-        } catch (InstantiationException | IllegalAccessException e) {
-            System.err.printf("Packet %s.class might hasn't got an empty constructor!%n\n", packets.get(id).getSimpleName());
-            e.printStackTrace();
-        }
-
-        return null;
-    }
-
-    public byte getPacketId(Packet packet) {
-        return packetBytes.get(packet.getClass());
-    }
-
-    public void registerListener(HydraPacketListener packetListener) {
+    protected void registerListener(HydraPacketListener packetListener) {
         if (packetListener == null) {
             throw new IllegalArgumentException("packetListener can't be null!");
         }

shared/src/main/java/de/datasec/hydra/shared/protocol/packets/PacketHandler.java

@@ -11,4 +11,5 @@
 @Target(ElementType.METHOD)
 @Retention(RetentionPolicy.RUNTIME)
 public @interface PacketHandler {
+
 }

shared/src/main/java/de/datasec/hydra/shared/protocol/packets/serialization/PacketDecoder.java

@@ -26,6 +26,7 @@ protected void decode(ChannelHandlerContext context, ByteBuf in, List<Object> ou
         Packet packet = protocol.createPacket(in.readByte());
         packet.setByteBuf(in);
         packet.read();
+
         out.add(packet);
     }
 }

shared/src/main/java/de/datasec/hydra/shared/protocol/packets/serialization/PacketEncoder.java

@@ -23,8 +23,10 @@ public PacketEncoder(HydraProtocol protocol) {
     protected void encode(ChannelHandlerContext context, Packet packet, List<Object> out) throws Exception {
         ByteBuf byteBuf = context.alloc().buffer();
         byteBuf.writeByte(protocol.getPacketId(packet));
+
         packet.setByteBuf(byteBuf);
         packet.write();
+
         out.add(byteBuf);
     }
 }