-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum version? #522
Comments
Katie brought up having a separate styleguide for demos as well. Should we discuss this in the frondship meeting this week? |
I'm thinking about this (and this related issue)... it's true that each page of our website loads more CSS than it needs. But we also don't want to get in the business of generating a single, large, page-specific CSS file for each different page -- as @hanbyul-here noted, that would not allow for caching and would require the browser to re-download the CSS each time the user moves to a different page. So, here's a two-step proposal (entirely open for discussion):
Pros:
Cons:
Thoughts? |
I think this makes a lot of sense @rfriberg 😸 |
Sounds great @rfriberg! |
I don't think we've tracked performance in the past, but we def think about it (hence the pro/con list above). :) In digging into this, this strategy is not a huge kb-saver due to all the bootstrap dependencies. I'm going to think about this a little more. 🤔 HOWEVER, in digging around, I did find that most pages were calling the unminified versions of these stylesheets. I'm assuming that's an artefact or oversight so making PRs to change them now. (Let me know if it's intentional!) For reference, the unminified styleguide.css is 213 KB while the minified styleguide.min.css is 159 KB. |
The text was updated successfully, but these errors were encountered: