Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pelias results archiving functionality #388

Open
msmollin opened this issue Nov 2, 2017 · 2 comments
Open

Fix pelias results archiving functionality #388

msmollin opened this issue Nov 2, 2017 · 2 comments
Labels
Next

Comments

@msmollin
Copy link
Member

msmollin commented Nov 2, 2017

Pull in latest pelias release?
@RaimundWege
Copy link

RaimundWege commented Nov 24, 2017 •
edited
Loading

We are currently testing different MapViews with Xcode 9 and can't use this SDK because of an issue in the pelias dependency:
pelias
Is related to #341

@msmollin
Copy link
Member Author

msmollin commented Nov 24, 2017 •
edited
Loading

Interesting - yeah we're aware of that issue but it's not causing compiling errors for us in our Sample App. Can you possible share some implementation code?

We fixed it as part of the Swift 4 migration for Pelias however we then ran into the linked cocoapod issue in #341, so we've been holding off on upgrading Pelias in the main SDK until that cocoapod issue got resolved and the subsequent PRs merged.

If it's causing you issues we can revert the Swift 4 migration and patch it in Swift 3.x.

@msmollin msmollin added the Next label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RaimundWege @msmollin