Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dagger Dependency #451

Open
sarahsnow1 opened this issue Sep 13, 2017 · 5 comments
Open

Upgrade Dagger Dependency #451

sarahsnow1 opened this issue Sep 13, 2017 · 5 comments
Labels

Comments

@sarahsnow1
Copy link
Member

We are on 2.0 but at the time of writing the newest version is 2.11

https://github.com/google/dagger/releases

@BaN4NaJ0e
Copy link

Could you reopen this Issue? It is not possible to downgrade Dagger to version 2.0 in my project. And with v2.11 the mapzen library will not build.

My app is also using the kotlin annotation processor and the mapzen library is using the default gradle annotation processor. This combination is failing at the moment.

@msmollin
Copy link
Member

msmollin commented Oct 9, 2017

@BaN4NaJ0e Thanks for the 👍 to this work. Now that we have v1.6.1 out the door, we're going to be going through and upgrading all dependencies to latest versions.

I've created #479 to track the separate but likely related issue for the kotlin annotation processor build failures. Reopening the previous issue would only cause for confusion :)

@BaN4NaJ0e
Copy link

As a workaround for now I have build the mapzen sdk by myself. I have updated the dagger version inside the MapZen SDK to v2.12 and replaced the annotationProcessor with the Kotlin kapt version. So far everything seems to work. So you guys should have no problems to update all dependencies to latest versions too.

Looking forward for a new MapZen SDK release with the latest depencies. ;) Keep up the good work!

@msmollin
Copy link
Member

@BaN4NaJ0e fantastic! Would you want to submit that as a PR?

@BaN4NaJ0e
Copy link

All I did was changing the version numbers inside the build.gradle file and added the Kotlin Annotation Processor. So instead of writing:

annotationProcessor 'com.google.dagger:dagger-compiler:2.0'

I changed it to:

kapt 'com.google.dagger:dagger-compiler:2.11'

Do not forget to add the Kotlin Stuff at the top of the build gradle file:

apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt'

That was all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants