-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 19 upgrade #219
Comments
Maybe for some users would be great to have support for maplibre 5 with Angular 18. I think the breaking changes are relatively small which should still allow us to publish a version for angular 18. Perhaps release maplibre 5 under 18.2 and the next major release will be in sync again with angular 19. Too clarify the versioning between Angular/maplibre-gl and this library, we could add a version table to the readme:
| Angular | maplibre-gl | ngx-maplibre-gl |
|:---:|:---:|:---:|
| 18.x | >= 5.0.0 | 18.2.x |
| 18.x | >= 4.5.2 | 18.1.x |
| 18.x | >= 4.1.2 | 18.0.0 | |
I'll publish 18.2, the changelog should be enough in terms of compatibility I think, I'm not too keen on maintaining this kind of table... |
Totally understandable. The changelog is fine for me too |
18.2 was released. |
We'll need to make sure angular 19 is supported.
I think we already did most of the migration stuff as part of version 18, but we'll need to check.
There's a question if we should support maplibre 5 with angular 18 or with 19 only to better address the breaking change that we did with maplibre 5.
I honestly don't know.
Cc: @hheexx @marcjulian
The text was updated successfully, but these errors were encountered: