Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 19 upgrade #219

Open
HarelM opened this issue Jan 7, 2025 · 4 comments
Open

Angular 19 upgrade #219

HarelM opened this issue Jan 7, 2025 · 4 comments

Comments

@HarelM
Copy link
Collaborator

HarelM commented Jan 7, 2025

We'll need to make sure angular 19 is supported.
I think we already did most of the migration stuff as part of version 18, but we'll need to check.
There's a question if we should support maplibre 5 with angular 18 or with 19 only to better address the breaking change that we did with maplibre 5.
I honestly don't know.
Cc: @hheexx @marcjulian

@marcjulian
Copy link
Collaborator

Maybe for some users would be great to have support for maplibre 5 with Angular 18. I think the breaking changes are relatively small which should still allow us to publish a version for angular 18.

Perhaps release maplibre 5 under 18.2 and the next major release will be in sync again with angular 19.

Too clarify the versioning between Angular/maplibre-gl and this library, we could add a version table to the readme:

Angular  maplibre-gl  ngx-maplibre-gl
 18.x  >= 5.0.0  18.2.x
18.x  >= 4.5.2 18.1.x
 18.x   >= 4.1.2  18.0.0
| Angular | maplibre-gl | ngx-maplibre-gl |
|:---:|:---:|:---:|
| 18.x | >= 5.0.0 | 18.2.x |
| 18.x |  >= 4.5.2 | 18.1.x |
| 18.x |  >= 4.1.2 | 18.0.0 |

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 7, 2025

I'll publish 18.2, the changelog should be enough in terms of compatibility I think, I'm not too keen on maintaining this kind of table...

@marcjulian
Copy link
Collaborator

Totally understandable. The changelog is fine for me too

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 8, 2025

18.2 was released.
Having said that, there's still a need to update the code to align with Angular 19 as part of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants