Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniontiles.union should accept sequence of tuples or mercantile Tiles #39

Open
sgillies opened this issue Oct 5, 2020 · 3 comments
Open

Comments

@sgillies
Copy link
Contributor

sgillies commented Oct 5, 2020

I'm looking at some code which uses supermercado and is turning lists of numbers into strings just so supermercado can decode them into numbers again.

@sgillies sgillies assigned sgillies and unassigned sgillies Oct 5, 2020
@dnomadb
Copy link
Contributor

dnomadb commented Oct 5, 2020

@sgillies I agree! This "better python api" is what I was alluding to here: #30 (comment)

@dnomadb
Copy link
Contributor

dnomadb commented Oct 7, 2020

@sgillies looking back into this, I was reminded of what Damon-from-5-years-ago-was thinking: union optionally takes a "parsenames" option that would parse "tiley" strings:

tiles = sutils.tile_parser(inputtiles, parsenames)
. Two options:

  1. We remove this altogether and point to xt or equivalent docs
  2. We leave it and support strings only if parse_names is True

@sgillies
Copy link
Contributor Author

@dnomadb I'd prefer option 1. I've done 2 for shapely and regretted it after a while. I like the example of Python's trig functions. These could all be, for example, def acos(x, is_degrees=False) but one kind of input and another method to convert inputs is the simplest to support in the long haul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants