-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModelLayer disappears abruptly on panning when pitch is applied #2152
Comments
@qandeelabbassi Thanks. This issue is related to tile cover: internally, geojson is split into tiles, and when the underlying tile gets out of the viewport, each of the 3D model objects anchored to the positions on that tile is not rendered. We will work on resolving this. Meanwhile, as a workaround, would it help to lower layer.maxZoom = 22, to e.g. layer.maxZoom = 5? Larger tiles (occupying larger geometry) would be less likely to get out of the viewport. The workaround would be problematic for a high zoom situations due to precision loss. |
@astojilj, thanks for the quick response.
But the models never get out of the viewport in the above video. My understanding of the viewport might be incorrect, so I would like to know what viewport you are referring to here.
According to my understanding, decreasing the maxZoom would cause the model to disappear quickly or when we get closer to the model. Wouldn't this worsen the issue? |
@qandeelabbassi
I meant GeoJSONSource source's maxzoom.
Models don't, but the tile on the ground gets out of viewport. This we need to resolve but I hope that the workaround (lower maxzoom for source) would help on this meanwhile. |
@astojilj, setting maxzoon on geojson source doesn't solve the issue. If i use 3D puck would it solve the problem? |
3D puck should solve the issue, and could be used as a workaround until we fix this, since the underlying data is not tiled. |
@astojilj using |
@qandeelabbassi thanks, good to know that the workaround helped. We are working on a proper solution for this |
@astojilj Although maxZoom solves the described issue, it causes the model to shift away from the center of the map. Any idea how I can fix this? |
Environment
Observed behavior and steps to reproduce
ModelLayer disappears abruptly on panning when pitch is applied. Sometimes, initially, it doesn't even appear until I move the camera around
Code for adding model
Code for setting camera:
Video
recording.mov
Expected behavior
The model shouldn't disappear
The text was updated successfully, but these errors were encountered: