Skip to content

Commit d3ce65c

Browse files
committed
🐛 restore triggers handleMainWindowResize
Allows startMinimized to work properly on Windows Signed-off-by: Marc Nuri <[email protected]>
1 parent c21c1b0 commit d3ce65c

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/main/__tests__/index.test.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,23 @@ describe('Main module test suite', () => {
188188
expect(settingsModule.updateSettings).toHaveBeenCalledWith({width: 13, height: 37});
189189
});
190190
});
191+
describe('restore (required for windows when starting minimized)', () => {
192+
let mockAppMenu;
193+
beforeEach(() => {
194+
mockAppMenu = {
195+
setBounds: jest.fn()
196+
};
197+
jest.spyOn(appMenuModule, 'newAppMenu').mockImplementation(() => mockAppMenu);
198+
main.init();
199+
});
200+
test('should set app-menu bounds', () => {
201+
// When
202+
mockBrowserWindow.listeners.restore({sender: mockBrowserWindow});
203+
jest.runAllTimers();
204+
// Then
205+
expect(mockAppMenu.setBounds).toHaveBeenCalledWith({x: 0, y: 0, width: 10, height: 34});
206+
});
207+
});
191208
describe('resize', () => {
192209
test('#78: should be run in separate setTimeout timer function to resize properly in Linux', () => {
193210
// When

src/main/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ const init = () => {
272272
mainWindow.show();
273273
}
274274
mainWindow.removeMenu();
275-
['resize', 'maximize']
275+
['resize', 'maximize', 'restore']
276276
.forEach(event => mainWindow.on(event, handleMainWindowResize));
277277
mainWindow.on('close', handleWindowClose);
278278
initTabListener();

0 commit comments

Comments
 (0)