Fixed unhandled exception when plotting a live event histogram #36775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixed unhandled exception found in manual testing, as detailed in #36726
Summary of work
Caught
RunTime
error exception and replaced it by logging an error to the console.Avoids an uncaught exception. This behaviour was already present in previous versions of mantid.
Fixes #36726 .
Further detail of work
This error only happens at a high updating fequency. When we select the live data interface to update every 1 second, the workspace in the ADS gets rewritten every 1 second. When the plotting is still loading the data will change, which causes a RunTime error:
Variable invalidated, data has been deleted.
. If you select this update to 5 seconds, the plot will usually happen with no issues.To test:
Here is a summary:
TEST_LIVE
andISIS_HISTOGRAM
FakeISISEventDAE
(use defaults)FakeISISHistoDAE
(use defaults)Instrument: ISIS_Histogram
Connection: Histo
Starting time: Now
Update every: 1 second
No processing
Accumulation method: Replace
No processing
Output workspace: live_histo_ws
An error should be logged saying that data has been deleted.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.