Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for PolarizationCorrectionsHelpers methods #37749

Open
rbauststfc opened this issue Aug 6, 2024 · 0 comments · May be fixed by #38602
Open

Improve test coverage for PolarizationCorrectionsHelpers methods #37749

rbauststfc opened this issue Aug 6, 2024 · 0 comments · May be fixed by #38602
Assignees
@yusufjimoh
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS
Milestone
Release 6.13

Comments

@rbauststfc
Copy link
Contributor

Some helper methods were added in PolarizationCorrectionsHelpers.cpp and tests were added for one of these methods. While the method that's being tested makes use of the other methods in the file, we should still really provide tests for all of the methods individually, so it would be good to review and extend existing test coverage here.
@rbauststfc rbauststfc added Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Aug 6, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Aug 6, 2024
@rbauststfc rbauststfc mentioned this issue Aug 6, 2024
Merged
@rbauststfc rbauststfc added this to the Release 6.11 milestone Aug 21, 2024
@rbauststfc rbauststfc modified the milestones: Release 6.11, Release 6.12 Sep 13, 2024
@rbauststfc rbauststfc moved this from Icebox to Backlog in ISIS LSS Sprint Planning Dec 2, 2024
@rbauststfc rbauststfc moved this from Backlog to In Progress in ISIS LSS Sprint Planning Jan 7, 2025
@rbauststfc rbauststfc moved this from In Progress to Backlog in ISIS LSS Sprint Planning Jan 8, 2025
@rbauststfc rbauststfc moved this from Backlog to In Progress in ISIS LSS Sprint Planning Jan 9, 2025
@yusufjimoh yusufjimoh linked a pull request Jan 14, 2025 that will close this issue
Improve test coverage for PolarizationCorrectionsHelpers methods #38602
Open
@yusufjimoh yusufjimoh linked a pull request Jan 14, 2025 that will close this issue
Open
@rbauststfc rbauststfc modified the milestones: Release 6.12, Release 6.13 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusufjimoh yusufjimoh

Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS
Projects
ISIS LSS Sprint Planning
Status: In Progress
Milestone
Release 6.13
Development

Successfully merging a pull request may close this issue.

Improve test coverage for PolarizationCorrectionsHelpers methods mantidproject/mantid
2 participants
@rbauststfc @yusufjimoh