-
Notifications
You must be signed in to change notification settings - Fork 129
Polarized SANS metadata: add SavePolarizedNXcanSAS to SANSSave #38523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
SANS
Issues and pull requests related to SANS
Milestone
Comments
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
We can use match/case statements in python 3.10! RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 4, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 23, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 23, 2025
We can use match/case statements in python 3.10! RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 23, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 23, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 23, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 24, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 24, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 24, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 24, 2025
We can use match/case statements in python 3.10! RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 24, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 30, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 30, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 30, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Apr 30, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 14, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 14, 2025
The correct format of NXcanSAS has a lowercase can. Make this the place throughout the project to avoid confusion. RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 14, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 14, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
We can use match/case statements in python 3.10! RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
The correct format of NXcanSAS has a lowercase can. Make this the place throughout the project to avoid confusion. RE mantidproject#38523
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
SANS
Issues and pull requests related to SANS
Uh oh!
There was an error while loading. Please reload this page.
Part of #36147. See the design and requirements documents, and the NXcanSAS specification proposal, that are linked on that issue for more context and details of what needs to be implemented.
After adding a new
SavePolarizedNXcanSAS
algorithm we need to add it to theSANSSave
algorithm. This will be the first step towards integrating this new save option into the SANS reduction.The
SavePolarizedNXcanSAS
algorithm will have quite a lot of new input properties. To avoid adding this long list toSANSSave
, we should investigate adding just a single additional property that will take a dictionary of the polarized metadata property values to be passed toSavePolarizedNXcanSAS
. This would be something like theMergeRunsOptions
property on theLoadAndMerge
algorithm. We would need to pass a nested dictionary toSANSSave
, which I think should be fine from a technical perspective, but we’ll need to double check.From a usability perspective this approach is still not ideal, but I think we will expect people to use
SavePolarizedNXcanSAS
if they are using a save algorithm directly in their own scripts. From a maintainability perspective, this approach will hopefully make it easier to maintain and support developments to the SANS save algorithms in the future.This issue should not be worked on until #38505 has been completed.
The text was updated successfully, but these errors were encountered: