Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Presenter Subscriber classes in Muon ALC interface #38488

Open
robertapplin opened this issue Dec 9, 2024 · 0 comments
Open

Rename the Presenter Subscriber classes in Muon ALC interface #38488

robertapplin opened this issue Dec 9, 2024 · 0 comments
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons

Comments

@robertapplin
Copy link
Contributor

Description
The presenter subscriber classes in the Muon ALC interface might be better called Callback classes. For instance:

  • IALCDataLoadingPresenterSubscriber might be better as IALCDataLoadingPresenterCallback

There are also the similiar classes for ALCBaselineModellingPresenter and ALCPeakFittingPresenter.

Acceptance criteria

  • Better names are used for the Presenter subscriber classes in the Muon ALC interface
@robertapplin robertapplin converted this from a draft issue Dec 9, 2024
@robertapplin robertapplin added Muon Issues and pull requests related to muons Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Dec 9, 2024
@robertapplin robertapplin mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
ISIS Spectroscopy
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertapplin