Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure cmake to generate pre-compiled headers #38474

Open
peterfpeterson opened this issue Dec 4, 2024 · 0 comments
Open

Configure cmake to generate pre-compiled headers #38474

peterfpeterson opened this issue Dec 4, 2024 · 0 comments
Assignees
@thomashampson
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Windows Only Only on Windows

Comments

@peterfpeterson
Copy link
Member

During the work on #38332 it was discovered that there are several hand-written pre-compiled headers for windows (example). There are also a custom cmake function written by mantid. These should be replaced with the cmake 3.16 function to automate their creation in the build-tree similar to the generated headers for dllexports.

This is related to #38457 which will remove the hand-written MantidKernel/System.h.
@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Dec 4, 2024
@peterfpeterson peterfpeterson added the Windows Only Only on Windows label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomashampson thomashampson

Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Windows Only Only on Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterfpeterson @thomashampson