-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct error calculation to PolarizationEfficienciesWildes #37768
Comments
TBC Phi: Error calculation: |
TBC Fp: Error calculation: |
TBC Fa: Error calculation: |
TBC Polarizer efficiency If calculating from mag workspace: Error calculation: Otherwise, if calculating from the analyser efficiency: Error calculation: |
TBC Analyser efficiency: Error calculation: |
TBC Rho:Error calculation: Alpha:Error calculation: Two p minus 1:Error calculation: Two a minus 1:Error calculation: |
Having a very quick look, I think for the However, I think for the other quantities, because they use derived quantities (i.e. Now it may be these give equivalent results for the two ways of calculating (I must admit I need to do more reading on this), but it is worth a check. |
Thanks for the comments so far @acaruana2009, I get what you're saying about the derived quantities. I'll leave that one with you (definitely beyond my level of knowledge on this!) and just let me know what you find out. |
I think here you need to substitute in the equation for UPDATE: Sorry I see @acaruana2009 has already commented something similar! I think we can check any error propagation numerically, i.e. generate normally distributed counts |
The
PolarizationEfficienciesWildes
algorithm currently uses default Mantid error calculation, which is expected to over-estimate the errors. We need to add bespoke error calculations for the equations being calculated in this algorithm to improve the accuracy. The errors should be calculated using the same approach as we have done for the SANS efficiency algorithms.This is part of the Polarised Reflectivity epic and a follow-on from issue #35682.
We will need to confirm the error equations to be implemented here. Either the scientists will need to provide these, or we can attempt to derive them using the same approach as we used for SANS and then confirm with our scientists that they are correct before implementing.
The text was updated successfully, but these errors were encountered: