Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Polarised reflectivity reduction in NR GUI #34294

Open
4 of 13 tasks
gemmaguest opened this issue Aug 18, 2022 · 1 comment
Open
4 of 13 tasks

EPIC: Polarised reflectivity reduction in NR GUI #34294

gemmaguest opened this issue Aug 18, 2022 · 1 comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry Reported By User Issues that were found or highlighted by a user/scientist

Comments

@gemmaguest
Copy link
Contributor

gemmaguest commented Aug 18, 2022

Some changes are required to be able to run Polref experiments in the ISIS Reflectometry GUI. This would be particularly useful for soft matter users, who are more familiar with the GUI than with the scripts that Polref currently uses. Some of the additional steps used/required for Polref would also be useful for the other instruments, so there is benefit in consolidating the workflows.

A brief summary of the main steps required, in order of priority, is:

Perform polarisation correction:

Additional steps required for Polref reduction:

  • Calibration step for POLREF reductions #34934 - change theta-in based on the calibration file. For summing in Q, need to do full pixel adjustment from the calibration. Review requirements against the algorithm we have already added for INTER, as POLREF should be similar but they measure positions in angles rather than mm.
  • Fit the specular peak using Bumps or similar.

General improvements:

  • There are currently some bugs in producing the workspace history from the workflow algorithms used by the GUI, in particular when the input is a workspace group. We should fix this so we can fully reproduce the reduction, and it would also aid with transparency.
  • Add output stitch options to parameters file #34843 - Adding output stitch options to the parameters file.
  • Improving stitched group child workspace names. Also polarization workspace names have been mentioned.

New features:

  • Get the error on the fitted peak from the fitter. Bayesian analysis preferred, but would want to be able to turn this off because it's very slow.
  • Add diagnostic tools to the GUI to be able to view the flood workspace, background subtraction workspace etc. Using these tools, it should be possible to auto-populate ROIs from fitting performed using the diagnostic tools to speed up the process of entering all the required settings by hand. It should then be possible to manually change these settings, while preventing any further diagnostic fitting from overwriting them.
  • Polref run experiments where each sample is very different and requires all the cropping lambda/Q ranges etc. to be adjusted for every run. This is currently quite cumbersome in the GUI because it requires clicking on boxes in different tabs to edit each start and end value. It would be good to think about how we might streamline this.
@gemmaguest gemmaguest added Reflectometry Issues and pull requests related to reflectometry ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Aug 18, 2022
@gemmaguest gemmaguest added this to the Release 6.6 milestone Oct 18, 2022
@gemmaguest gemmaguest removed this from the Release 6.6 milestone Nov 3, 2022
@gemmaguest gemmaguest added the Reported By User Issues that were found or highlighted by a user/scientist label Nov 14, 2022
@gemmaguest gemmaguest changed the title Polarised reflectivity reduction in NR GUI EPIC: Polarised reflectivity reduction in NR GUI Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry Reported By User Issues that were found or highlighted by a user/scientist
Projects
Status: Backlog
Development

No branches or pull requests

2 participants