Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String interpolation doesn't work with manifold-ij #29

Closed
ice1000 opened this issue May 14, 2024 · 16 comments
Closed

String interpolation doesn't work with manifold-ij #29

ice1000 opened this issue May 14, 2024 · 16 comments

Comments

@ice1000
Copy link
Contributor

ice1000 commented May 14, 2024

image

It doesn't work! Env same as #27 but with manifold-ij updated

@rsmckinney
Copy link
Member

Sorry about that,fix coming in tomorrows plugin release.

@ice1000
Copy link
Contributor Author

ice1000 commented May 14, 2024

Sorry about that,fix coming in tomorrows plugin release.

No worries! Btw, it looks like records with @link are still unsupported (manifold-systems/manifold#587), I tried to use gradle to compile, and it gives me errors about methods being unimplemented. Should I file an issue, or should I wait for a release?

@rsmckinney
Copy link
Member

it looks like records with @link are still unsupported (manifold-systems/manifold#587),

The plugin release scheduled for Monday was delayed due to a couple of other issues that have surfaced. The release will be available by EOD tomorrow. Thanks for your patience.

@ice1000
Copy link
Contributor Author

ice1000 commented May 14, 2024

No worries! I was just curious.

@rsmckinney
Copy link
Member

Regarding Java string interpolation not working, I'm not seeing that. It works for me with plugin release 2024.1.0 using JDK 21 Preview, also works with JDK 22 Preview.

@ice1000
Copy link
Contributor Author

ice1000 commented May 14, 2024

The plugin release scheduled for Monday was delayed due to a couple of other issues that have surfaced.

In the issue, you mentioned it already works, but the intellij plugin needs to be updated. However, compilation also does not work for me.

Do you need MWE? I'll try to come up with one later

@rsmckinney
Copy link
Member

compilation also does not work

It should work... What happens if you test a simple example?

  System.out.println(new MyRecord("hi").charAt(0));

  record MyRecord(@link CharSequence cs) implements CharSequence {
  }

@ice1000
Copy link
Contributor Author

ice1000 commented May 14, 2024

I'll try to figure out later. I'm in a meeting right now.

@ice1000
Copy link
Contributor Author

ice1000 commented May 15, 2024

I've updated the code to use CharSequence and it still reproduces the error

@rsmckinney
Copy link
Member

It all works for me. Is your project available or can your provide your build files? I just need a way to reproduce your environment so I can reproduce this. If you have a simple sample project that would be even better. Thanks.

@ice1000
Copy link
Contributor Author

ice1000 commented May 16, 2024

It all works for me. Is your project available or can your provide your build files? I just need a way to reproduce your environment so I can reproduce this. If you have a simple sample project that would be even better. Thanks.

The links above belong to a minimal gradle project, you can checkout and reproduce the error by using ./gradlew classes

@ice1000
Copy link
Contributor Author

ice1000 commented May 16, 2024

The code is here: https://github.com/ice1k/manifold-java-bug-report

@ice1000
Copy link
Contributor Author

ice1000 commented May 16, 2024

The link I gave you earlier is the execution log of a continuous-integration system that is nowadays very popular called GitHub Actions. The code that used to generate that log can be found in the .github/workflows folder of the repository.

@rsmckinney
Copy link
Member

Your gradle.build.kts file is missing the vital "-Xplugin:Manifold" compiler argument. See setup docs.

image

@ice1000
Copy link
Contributor Author

ice1000 commented May 16, 2024

Your gradle.build.kts file is missing the vital "-Xplugin:Manifold" compiler argument. See setup docs.

image

!!!!!!!!!!!!! Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants