Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider appending "via [insert_name] assembly" to applicable rule names #979

Open
mike-hunhoff opened this issue Jan 8, 2025 · 3 comments · May be fixed by #1011
Open

consider appending "via [insert_name] assembly" to applicable rule names #979

mike-hunhoff opened this issue Jan 8, 2025 · 3 comments · May be fixed by #1011
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mike-hunhoff
Copy link
Collaborator

As we've extended capa to process multiple architectures we should consider appending via [insert_name] assembly to applicable rule names. This should help users better distinguish capa's rules and results.

e.g. https://github.com/mandiant/capa-rules/blob/ff9db744255ecd9d5f5e64c4b93af7613a9441f2/data-manipulation/encryption/rc4/encrypt-data-using-rc4-prga.yml can only match x86 assembly but this is not obvious based on the rule name.

@mike-hunhoff mike-hunhoff added enhancement New feature or request good first issue Good for newcomers labels Jan 8, 2025
@akh7177
Copy link

akh7177 commented Feb 26, 2025

Hey @mike-hunhoff ,

I'd like to work on this issue. Could you please assign it to me?

I have a question regarding this issue. Do I need to go through each yml file or are there any particular folders that have architecture specific yml rule files in them?

Thanks!

@williballenthin
Copy link
Collaborator

Yes, thats correct. When a rule relies on architecture-specific assembly (typically mnemonics), and would never match on a different architecture, then the rule name should be updated. This will require going through the existing yml rules. They are not found in a particular namespace, so all rules are in scope.

@akh7177
Copy link

akh7177 commented Feb 26, 2025

Got it!

Will start working on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants