[BUG] Docker container does not stop in oneshot mode

[tymmej]

Describe the bug
I have configured drive and photos sync to one shot by setting -1 to interval.
After running docker image I expect that it will finish after syncing once.

To confirm I added && echo "end" to init.sh:

2024-10-10 06:26:45,572 :: INFO :: root :: sync.py :: 75 :: Syncing drive...
2024-10-10 06:26:45,572 :: INFO :: root :: sync.py :: 77 :: Drive synced
2024-10-10 06:26:45,572 :: INFO :: root :: config_parser.py :: 83 :: Syncing drive every -1 seconds.
2024-10-10 06:26:45,572 :: INFO :: root :: sync.py :: 80 :: Syncing photos...
2024-10-10 06:26:45,572 :: INFO :: root :: sync.py :: 82 :: Photos synced
2024-10-10 06:26:45,572 :: INFO :: root :: config_parser.py :: 98 :: Syncing photos every -1 seconds.
2024-10-10 06:26:45,573 :: INFO :: root :: sync.py :: 131 :: Resyncing at Thu Oct 10 06:26:45 2024 ...
2024-10-10 06:26:45,573 :: INFO :: root :: config_parser.py :: 83 :: Syncing drive every -1 seconds.
2024-10-10 06:26:45,573 :: INFO :: root :: config_parser.py :: 83 :: Syncing drive every -1 seconds.
end
[image still runing]
^C^\%

To Reproduce
Steps to reproduce the behavior:

1. Set both sync_intervals to -1
2. Wait for sync
3. See that docker container is still running

Expected behavior
Docker container is stopped after syncing

[robdejonge]

This also happens to me.

2024-11-30 15:56:43,719 :: INFO :: root :: sync.py :: 77 :: Drive synced
2024-11-30 15:56:43,719 :: INFO :: root :: config_parser.py :: 83 :: Syncing drive every -1 seconds.
2024-11-30 15:56:43,720 :: INFO :: root :: sync.py :: 129 :: Resyncing at Sat Nov 30 15:56:42 2024 ...
2024-11-30 15:56:43,720 :: INFO :: root :: config_parser.py :: 83 :: Syncing drive every -1 seconds.

[nicx]

same behaviour here. would be great if the container stops.

[nicx]

@mandarons a short addition: same problem when using "retry_login_interval: -1". My expectation would be the docker container stops after the first login failed. but it just does not. is it the same problem? or should I open another bug?

[mandarons]

me problem when using "retry_login_interval: -1". My expectation would be the docker container stops after the first login failed. but it just does not. is it the same problem?

When retry_login_interval is set to -1, it indicates try login only once. This affects only the login flow retries and not whole application. Hence, it correctly won't cause whole application to exit.

Setting sync_interval to -1 should cause application exit (which appears to be not happening, hence this bug).

[nicx]

@mandarons is it possible to exit the container too when the login fails? otherwise I would not recognize in any way that the sync process is no more working.

[mandarons]

Yeah, that's possible. I typically get notifications if logins are failing. But there is no point in keeping the container running if login is failing and retry_login_interval is set to -1.

Let me see if I can handle this case as well once I figure out solution to this bug.