New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips: consider standardizing the data attributes #15

Open

hidegh opened this issue Dec 14, 2022 · 0 comments

hidegh commented Dec 14, 2022 •

edited

data-josh-anim-name="lightSpeedInRight"
data-josh-duration="1500ms"
data-josh-anim-delay="3.5s"
data-josh-iteration="infinite"

isnt the duration and iteration related to anim?
the why don't we use data-josh-anim- prefix?
or why even use data-josh-anim- and not just data-josh- since the library itself is around animation ❓

as this is a breaking change, advising:

updating major version and use just data-josh-delay, etc. names
updating readme and leave a note on this there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment