User break in debugger bypass UI toggle

[angelosa]

Steps to reproduce:

• Launch a computer system with keyboard attached, preferably one with a DOS shell, mamefoo ibm5160 -isa3:fdc_xt:fdc:0 35dd -flop1 msdos401_35:flop3 -debug if you don't have one handy;
• Set UI toggle to disable controls;
• Press your mapped "break in debugger" as long as it's mapped to the same keyboard as the one emulated and it's supposed to print a char to the terminal;

Expected behaviour:

• Debugger won't popup, prints the char.

Actual:

• Debugger will break in. Will also break without printing the char if the debugger is visible and the UI toggle is off.

[rb6502]

This is intended behavior. -debug always has implied that some things change to make debugging easier, and one of those things is making the debug key always available.

[angelosa]

Well it's not a very convenient behaviour when say, you have the Italian keyboard layout and have to type fullpaths in DOS, it will throw a debugger break on every subdirectory typed.

[cuavas]

That’s why you can reassign the debugger key. Reassign it to some weird combination of keys and/or joystick buttons that you don’t need for typing.