-
Notifications
You must be signed in to change notification settings - Fork 41
Description
When I run functions that use sites analyses, e.g.:
g123_test = adir1.g123_gwss()
I have the option to enter a phasing analysis. For ag3, af1, etc this is fine, but amin1 and adir1 we don't have a phasing analysis yet.
I've kind of hacked around this by putting something like "noneyet" for the phasing analysis in the config and classfiles. If I replace the dummy phasing analysis IDs with "None", I get an error like so:
173 name = "g123_gwss_v1"
175 if sites == base_params.DEFAULT:
--> [176](https://file+.vscode-resource.vscode-cdn.net/Users/dennistpw/github/vobs-asia/work/amin1-data-reorganisation-20251019/~/github/tristanpwdennis/malariagen-data-python/malariagen_data/anoph/g123.py:176) assert self._default_phasing_analysis is not None
177 sites = self._default_phasing_analysis
178 valid_sites = self.phasing_analysis_ids + ("all", "segregating")
Clearly not happy about not having the phasing analysis ID. While my placeholder works fine for me for the moment, perhaps when we release these it could be nice to modify this so - at least for analyses that only use unphased data - we don't have the requirement of needing a phasing analysis? I am happy to try and implement this if folks are in agreement.
In relation to #795