Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more functionalities to the data converter for use with plink #730

Open
jonbrenas opened this issue Mar 12, 2025 · 0 comments
Open
Labels
BMGF-062921 Work supported by BMGF grant INV-062921 (EAVeS). enhancement New feature or request triage

Comments

@jonbrenas
Copy link
Collaborator

jonbrenas commented Mar 12, 2025

While working on GWAS for EAVES, I have observed that adding some functionalities to biallelic_snps_to_plink would make my life easier. Namely:

  1. The current version doesn't store the sex calls in the .fam file and plink complains about that (it can be silenced but it should be easy to add the option to have the correct sex calls)
  2. There is no option to provide phenotypes which is kind of an issue for GWAS
  3. The names of the files are "hardcoded": they are defined as {region}.{n_snps}.{min_minor_ac}.{max_missing_an}.{thin_offset} which is fine as a default but should be modifiable
  4. It requires a n_snp (i.e., it is not optional) which is inconvenient when one wants to use as many SNPs as possible.
  5. Not sure it will ever be needed but we could also let the user provide a family tree (in what form, I am not sure yet) to fully use the functionality offered by the fam file.
    I will only start working on this if people agree that it makes sense. Feel free to add other ideas and suggestions, if you have any.
@jonbrenas jonbrenas added BMGF-062921 Work supported by BMGF grant INV-062921 (EAVeS). enhancement New feature or request labels Mar 12, 2025
@jonbrenas jonbrenas changed the title Potential updates to to_plink Adding more functionalities to the data converter for use with plink Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMGF-062921 Work supported by BMGF grant INV-062921 (EAVeS). enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant