Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of the service classes #207

Closed
joepal1976 opened this issue Aug 2, 2024 · 1 comment
Closed

Improve test coverage of the service classes #207

joepal1976 opened this issue Aug 2, 2024 · 1 comment
Assignees
Labels
code quality / refactoring Issue that doesn't change functionality or fixes a bug, but relates to quality and maintainability
Milestone

Comments

@joepal1976
Copy link
Contributor

Pretty much all of the core logic is implemented through service classes with static utility methods. These are all written to be agnostic as to what the user is doing with the interface. Ideally, they should have close to full direct test coverage.

At the moment, only a few of the service classes have direct test coverage (ie unit tests that calls the method of the class directly). However, as the classes call each other, a few classes have indirect test coverage that way.

At least the following very important service classes should have direct and specific unit tests:

  • AssetService
  • ClothesService
  • LogService
  • RigService
  • SystemService
  • UiService

The other service classes (such AnimationService, the config sets etc) are less critical.

@joepal1976 joepal1976 added the code quality / refactoring Issue that doesn't change functionality or fixes a bug, but relates to quality and maintainability label Aug 2, 2024
@joepal1976 joepal1976 added this to the 2.0 stable milestone Aug 2, 2024
@joepal1976 joepal1976 self-assigned this Aug 2, 2024
@joepal1976 joepal1976 modified the milestones: 2.0 stable, 2.0 beta 2 Aug 11, 2024
@joepal1976
Copy link
Contributor Author

Good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality / refactoring Issue that doesn't change functionality or fixes a bug, but relates to quality and maintainability
Projects
None yet
Development

No branches or pull requests

1 participant