Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Include Git LFS files in archives #3

Open
pekkarr opened this issue Jul 6, 2022 · 4 comments
Open

[feature request] Include Git LFS files in archives #3

pekkarr opened this issue Jul 6, 2022 · 4 comments

Comments

@pekkarr
Copy link

pekkarr commented Jul 6, 2022

Including Git LFS files in source code archives would make it easier to package makehuman for Linux distributions. Downloading assets via a tar/zip archive is usually the preferred way to download build sources compared to downloading with git-lfs.

Currently the generated archives (example) contain only references to large files and the actual git-lfs files are missing, which makes the archives practically unusable.

It's possible to include git-lfs files in archives from Github repository settings. The option is under General -> Archives -> Include Git LFS objects in archives.

@joepal1976
Copy link
Contributor

Ok. This option did not exist when we created this repo, but I have enabled it now.

We'll see how this affect the billing. If people start downloading huge zip files now and then instead of keeping a git directory to update, we might hit the quota sooner rather than later.

@pekkarr
Copy link
Author

pekkarr commented Jul 9, 2022

Thank you. I have updated the AUR build script (for Arch Linux) to use the tar archive as source for now. This leads probably to lower bandwidth usage from Arch users as the previous implementation didn't cache git-lfs files between package rebuilds.

It would also be helpful to use git tags to mark the commits that are supposed to be used with a specific makehuman version (so v1.2.0 makehuman-assets would be used with makehuman v1.2.0).

@joepal1976
Copy link
Contributor

Seems the only tag missing was for 1.2.0. I've pushed this.

@joepal1976
Copy link
Contributor

As feared, we rather quickly hit the bandwidth quota after this change. The download functionality is probably locked for now.

The quota will reset tomorrow and I'll evaluate the settings during the next month.

I'm generally disinclined to radically increase spending on LFS traffic. If the repo hits the limit again, we'll have to figure out some other solution.

archlinux-github pushed a commit to archlinux/aur that referenced this issue Aug 3, 2022
Upstream included git-lfs files in archives which makes this possible.
See makehumancommunity/makehuman-assets#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants