DKIM selector inconsistent

[cryopath]

Contribution guidelines

• I've read the contribution guidelines and wholeheartedly agree

I've found a bug and checked that ...

• ... I understand that not following the below instructions will result in immediate closure and/or deletion of my issue.
• ... I have understood that this bug report is dedicated for bugs, and not for support-related inquiries.
• ... I have understood that answers are voluntary and community-driven, and not commercial support.
• ... I have verified that my issue has not been already answered in the past. I also checked previous issues.

Description

When creating a DKIM key there is a dangling selector insinde the string that is always "email", regardless of the set selector.

Sent mails are sent with the correct descriptor.
The UI says to add it to the correct descriptor subdomain, but with an incorrect s= field in the record string.

Logs:

compose logs --since 20m | grep -i dkim

nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:41:54 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 143 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:42:15 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 129 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:44:00 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 135 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:44:13 +0200] "POST /api/v1/delete/dkim HTTP/2.0" 200 102 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:44:25 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 128 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:51:20 +0200] "POST /api/v1/delete/dkim HTTP/2.0" 200 102 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:51:45 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 137 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:52:08 +0200] "POST /api/v1/delete/dkim HTTP/2.0" 200 103 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
nginx-mailcow-1      | MXIP - - [15/Oct/2024:16:52:18 +0200] "POST /api/v1/add/dkim HTTP/2.0" 200 129 "https://my.censored.domain/" "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"

Steps to reproduce:

Add new domain, set a selector that is not "email" for DKIM.

Which branch are you using?

master

Which architecture are you using?

x86

Operating System:

Debian Bookworm

Server/VM specifications:

4

Is Apparmor, SELinux or similar active?

no

Virtualization technology:

No idea

Docker version:

Whatever is in dockers repo for debian. Propably stable version

docker-compose version or docker compose version:

whatever came with docker

mailcow version:

2024-08a

Reverse proxy:

no external one

Logs of git diff:

Nothing related in config.
No code changes.

Logs of iptables -L -vn:

not relevant

Logs of ip6tables -L -vn:

not relevant

Logs of iptables -L -vn -t nat:

not relevant

Logs of ip6tables -L -vn -t nat:

not relevant

DNS check:

172.64.155.249
104.18.32.7

[milkmaker]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.