Issue on Admin Page after upgrade to 75

[brian-nelson]

After upgrading my instance from 74 to 75. When I go to the /admin page on my instance, I get the following extra API information.

It continues to appear at the bottom of each page after being logged in.

[arminask]

Same issue, it is being displayed in all pages, including the login page.

[m0rp30]

Same issue

[blok82]

Same here. Alias-page stuff on every page in admin environment..... Also, error when i try to start a backup

[arminask]

Same here. Alias-page stuff on every page in admin environment..... Also, error when i try to start a backup

Tested it, works fine for me:

[JoshData]

The admin page issue is probably a missing </div> in the HTML template.

@blok82 If the backup issue persists, please open a separate issue with more info. But probably it's related to the minor change made to backups in this update. (Backups are working for me.)

[brian-nelson]

I pulled the code this morning and It looks like there are two extra </div> tags after this PR was merged two weeks ago in the aliases.html file.

#2555

But I am not certain if they just need to be removed or something else structural needs to happen.

[Ron-Dot-Star]

I pulled the code this morning and It looks like there are two extra </div> tags after this PR was merged two weeks ago in the aliases.html file.

#2555

But I am not certain if they just need to be removed or something else structural needs to happen.

I removed the two DIV's and it works perfectly.

[starsoccer]

Are there any plans to do a hot fix to address/fix this?

[cspencer49519]

The stray /divs are at lines 85 and 86 of management/templates/aliases.html , for anyone looking

[nickperkins]

Remember to run systemctl restart mailinabox.service after you make the change.

[m0rp30]

The stray /divs are at lines 85 and 86 of management/templates/aliases.html , for anyone looking

Where can i find this file management/templates/aliases.html

[brian-nelson]

For me it was at /root/mailinabox/management/templates

I used find / -name "aliases.html" to locate it.

[brian-nelson]

It does look like there is more work to fix this permanently than just the 2 <div> tags. The layout is a bit wonky.

[maxrd2]

Here's the diff for what worked for me:
File is /root/mailinabox/management/templates/aliases.html

diff --git a/management/templates/aliases.html b/management/templates/aliases.html
index 8283928..6b2ce44 100644
--- a/management/templates/aliases.html
+++ b/management/templates/aliases.html
@@ -76,13 +76,11 @@
           <span class="catchall domainalias">any address on the alias domain</span>.
         </label>
       </div>
-    </div>
-  </fieldset>
-</div>
       <div id="addaliasForwardsToDiv" style="margin-top: .5em; margin-left: 1.4em; display: none;">
         <textarea class="form-control" rows="3" id="addaliasSenders" placeholder="one user per line or separated by commas"></textarea>
       </div>
     </div>
+  </fieldset>
   </div>
   <div class="form-group">
     <div class="col-sm-offset-1 col-sm-11">

[niladam]

For anyone encountering issues with this here are some instructions to easily get you on the right track.

Back up first

sudo cp /root/mailinabox/management/templates/aliases.html /root/mailinabox/management/templates/aliases.html.bak

Remove the two stray that appear right after the #addaliasForwardsToDiv block,

just before the submit-button form-group.

sudo perl -0777 -i -pe '
  s{(<div id="addaliasForwardsToDiv"[^>]*>\s*<textarea[^<]*</textarea>\s*</div>)\s*</div>\s*</div>(\s*<div class="form-group">)}
   {$1$2}s
' /root/mailinabox/management/templates/aliases.html

Verify the diff

diff /root/mailinabox/management/templates/aliases.html.bak /root/mailinabox/management/templates/aliases.html

Restart the management daemon so the template is re-read

sudo systemctl restart mailinabox